-
Notifications
You must be signed in to change notification settings - Fork 3
ACP client-only examples #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @ai-virtual-b! Would it be better to have this in https://github.com/Virtual-Protocol/acp-python/tree/feat_client_examples/examples/acp_base? together with some add-ons in that readme original idea was to that folder for "vanilla acp" example, and have other folders for other agent frameworks etc |
also should we add browse_agent here? |
I think we should check the socket connection before falling back to polling. Running both at once could cause the agent to receive duplicate instructions and double-sign the same memo for a single phase. If the socket is connected but not emitting events, the issue is with the socket and should be fixed there — not bypassed by polling. Right now, polling is enabled regardless of socket status, but ideally, if the socket works, we shouldn’t poll at all. wdyt? |
Hey @Ang-dot - as discussed, I see polling vs websocket as alternative approaches so i think this is ok. Polling would be a "safe" alternative that is
|
c2a0e4b
to
599432d
Compare
Address comments with updated examples |
599432d
to
b4e4f48
Compare
b4e4f48
to
c3ec578
Compare
Usage of the ACP Client SDK only for the entire ACP job workflow - with functions only as client methods as an alternative way to use the SDK that might be more intuitive.